-
Notifications
You must be signed in to change notification settings - Fork 13.9k
Add a new lint UNCONSTRUCTABLE_PUB_STRUCT
to detect unconstructable public structs
#146440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add a new lint UNCONSTRUCTABLE_PUB_STRUCT
to detect unconstructable public structs
#146440
Conversation
r? @davidtwco rustbot has assigned @davidtwco. Use |
UNCONSTRUCTIBLE_PUB_STRUCT
to detect unconstructible public structs
Would the lint fire on token structs that are public, have private fields, have no public constructor method, but expose a limited number of pre-constructed objects, e.g. through a static that contains an optional token? |
won't fire like private types used in such places |
480b1d7
to
021712b
Compare
Nominating for t-lang to decide whether we want this lint, then I'll review the implementation. Also, s/unconstructible/unconstructable. |
UNCONSTRUCTIBLE_PUB_STRUCT
to detect unconstructible public structsUNCONSTRUCTABLE_PUB_STRUCT
to detect unconstructable public structs
☔ The latest upstream changes (presumably #144607) made this pull request unmergeable. Please resolve the merge conflicts. |
6075d81
to
497ad71
Compare
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #147863) made this pull request unmergeable. Please resolve the merge conflicts. |
497ad71
to
b3b3a05
Compare
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Add a new lint UNCONSTRUCTABLE_PUB_STRUCT to detect unconstructable public structs, based on the following observations: