Port `#[automatically_derived]` to the new attribute parsing infrastructure #143779

JonathanBrouwer · 2025-07-11T10:19:31Z

Ports #[automatically_derived] to the new attribute parsing infrastructure for #131229 (comment)

r? @oli-obk
cc @jdonszelmann

rustbot · 2025-07-11T10:19:38Z

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

Some changes occurred in match checking

cc @Nadrieril

JonathanBrouwer · 2025-07-11T10:35:29Z

compiler/rustc_hir/src/hir.rs

@@ -1304,6 +1304,7 @@ impl AttributeExt for Attribute {
            Attribute::Parsed(AttributeKind::DocComment { span, .. }) => *span,
            Attribute::Parsed(AttributeKind::MayDangle(span)) => *span,
            Attribute::Parsed(AttributeKind::Ignore { span, .. }) => *span,
+            Attribute::Parsed(AttributeKind::AutomaticallyDerived(span)) => *span,


This change is needed to fix #143780 for automatically_derived. automatically_derived is part of a test case so this is necessary to add now. @jdonszelmann and I are discussing a general solution to this problem.

Kobzol · 2025-07-11T11:47:02Z

There are lots of these attributes produced by built-in derives, let's do a perf. run once this is ready.

bors · 2025-07-12T14:58:24Z

☔ The latest upstream changes (presumably #143810) made this pull request unmergeable. Please resolve the merge conflicts.

…ucture Signed-off-by: Jonathan Brouwer <[email protected]>

Signed-off-by: Jonathan Brouwer <[email protected]>

jdonszelmann · 2025-07-12T18:50:47Z

@bors try @rust-timer queue

… r=<try> Port `#[automatically_derived]` to the new attribute parsing infrastructure Ports `#[automatically_derived]` to the new attribute parsing infrastructure for #131229 (comment) r? `@oli-obk` cc `@jdonszelmann`

bors · 2025-07-12T18:51:59Z

⌛ Trying commit 68066b9 with merge bc14627...

bors · 2025-07-12T21:10:09Z

☀️ Try build successful - checks-actions
Build commit: bc14627 (bc146279bdc1ca321ed03225099bba4299bcd965)

rust-timer · 2025-07-12T23:48:05Z

Finished benchmarking commit (bc14627): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.1%]	1
Improvements ✅ (secondary)	-0.2%	[-0.3%, -0.2%]	8
All ❌✅ (primary)	-0.1%	[-0.1%, -0.1%]	1

Max RSS (memory usage)

Results (primary -1.1%, secondary -1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-1.1%	[-1.1%, -1.1%]	1
Improvements ✅ (secondary)	-4.0%	[-4.0%, -4.0%]	1
All ❌✅ (primary)	-1.1%	[-1.1%, -1.1%]	1

Cycles

Results (primary 1.4%, secondary 5.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.6%	[2.3%, 2.8%]	3
Regressions ❌ (secondary)	5.8%	[2.4%, 9.2%]	2
Improvements ✅ (primary)	-2.2%	[-2.2%, -2.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.4%	[-2.2%, 2.8%]	4

Binary size

Results (primary -0.1%, secondary -0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.3%, -0.0%]	71
Improvements ✅ (secondary)	-0.4%	[-1.8%, -0.0%]	31
All ❌✅ (primary)	-0.1%	[-0.3%, -0.0%]	71

Bootstrap: 464.174s -> 466.768s (0.56%)
Artifact size: 374.70 MiB -> 374.67 MiB (-0.01%)

oli-obk · 2025-07-13T05:15:43Z

@bors r+

bors · 2025-07-13T05:15:46Z

📌 Commit 68066b9 has been approved by oli-obk

It is now in the queue for this repository.

jdonszelmann · 2025-07-13T06:15:42Z

damn, no regressions?

bors · 2025-07-14T04:29:57Z

⌛ Testing commit 68066b9 with merge ad635e5...

bors · 2025-07-14T07:31:54Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing ad635e5 to master...

github-actions · 2025-07-14T07:35:13Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 9c3064e (parent) -> ad635e5 (this PR)

Test differences

Show 14 test diffs

14 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ad635e5d0696076b4412dd7db7b7e8c0867d6e0c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-1: 6198.6s -> 8956.0s (44.5%)
dist-aarch64-linux: 8137.9s -> 5852.0s (-28.1%)
aarch64-apple: 4724.2s -> 5827.1s (23.3%)
dist-apple-various: 6334.9s -> 7527.0s (18.8%)
dist-x86_64-apple: 9338.3s -> 8381.1s (-10.3%)
x86_64-apple-2: 4214.5s -> 3854.9s (-8.5%)
dist-x86_64-musl: 7019.0s -> 7578.3s (8.0%)
dist-aarch64-apple: 5389.4s -> 5807.3s (7.8%)
aarch64-gnu-debug: 4199.5s -> 3934.6s (-6.3%)
pr-check-1: 1679.3s -> 1583.0s (-5.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-07-14T08:47:08Z

Finished benchmarking commit (ad635e5): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.3%, -0.1%]	8
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 2.3%, secondary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	4.7%	[1.8%, 7.7%]	4
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-7.5%	[-7.5%, -7.5%]	1
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	2.3%	[-7.5%, 7.7%]	5

Cycles

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (primary -0.1%, secondary -0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.3%, -0.0%]	71
Improvements ✅ (secondary)	-0.4%	[-1.8%, -0.0%]	31
All ❌✅ (primary)	-0.1%	[-0.3%, -0.0%]	71

Bootstrap: 462.57s -> 465.735s (0.68%)
Artifact size: 374.65 MiB -> 374.64 MiB (-0.00%)

rustbot assigned oli-obk Jul 11, 2025

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 11, 2025

JonathanBrouwer commented Jul 11, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

JonathanBrouwer force-pushed the automatically_derived_parser branch from 8ffd1bf to 499af0e Compare July 11, 2025 11:32

JonathanBrouwer added 3 commits July 12, 2025 17:48

Port #[automatically_derived] to the new attribute parsing infrastr…

ef82007

…ucture Signed-off-by: Jonathan Brouwer <[email protected]>

Fix clippy & rustdoc-json

a1cfca3

Signed-off-by: Jonathan Brouwer <[email protected]>

Update uitest stderrs

68066b9

Signed-off-by: Jonathan Brouwer <[email protected]>

JonathanBrouwer force-pushed the automatically_derived_parser branch from 499af0e to 68066b9 Compare July 12, 2025 15:51

jdonszelmann mentioned this pull request Jul 12, 2025

Tracking issue: Attribute refactor #131229

Open

9 tasks

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 12, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 12, 2025

oli-obk approved these changes Jul 13, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 14, 2025

bors merged commit ad635e5 into rust-lang:master Jul 14, 2025
12 checks passed

rustbot added this to the 1.90.0 milestone Jul 14, 2025

Port #[automatically_derived] to the new attribute parsing infrastructure #143779

Port #[automatically_derived] to the new attribute parsing infrastructure #143779

Uh oh!

Conversation

JonathanBrouwer commented Jul 11, 2025

Uh oh!

rustbot commented Jul 11, 2025

Uh oh!

JonathanBrouwer Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Kobzol commented Jul 11, 2025

Uh oh!

bors commented Jul 12, 2025

Uh oh!

jdonszelmann commented Jul 12, 2025

Uh oh!

This comment has been minimized.

bors commented Jul 12, 2025

Uh oh!

bors commented Jul 12, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jul 12, 2025

Overall result: ✅ improvements - no action needed

Uh oh!

oli-obk commented Jul 13, 2025

Uh oh!

bors commented Jul 13, 2025

Uh oh!

jdonszelmann commented Jul 13, 2025

Uh oh!

bors commented Jul 14, 2025

Uh oh!

bors commented Jul 14, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 14, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Jul 14, 2025

Overall result: ✅ improvements - no action needed

Uh oh!

Uh oh!

Port `#[automatically_derived]` to the new attribute parsing infrastructure #143779

Port `#[automatically_derived]` to the new attribute parsing infrastructure #143779

JonathanBrouwer Jul 11, 2025 •

edited

Loading