Emit warning when there is no space between `-o` and arg #143719

xizheyin · 2025-07-10T06:22:37Z

getopt doesn't seem to have an API to check this, so we have to check the args manually.

r? compiler

rustbot · 2025-07-10T06:22:45Z

This PR modifies run-make tests.

jieyouxu

This seems reasonable, though I can imagine this might be a bit annoying. I'll defer to @wesleywiser for a second opinion.

tests/run-make/option-output-no-space/rmake.rs

jieyouxu · 2025-07-10T06:26:07Z

r? @wesleywiser (re. #142812)

rustbot · 2025-07-10T06:26:13Z

wesleywiser is not on the review rotation at the moment.
They may take a while to respond.

jieyouxu · 2025-07-10T06:26:43Z

Ah right. I'll wait a bit in case Wesley has feedback.
r? jieyouxu

jieyouxu · 2025-07-10T06:31:42Z

compiler/rustc_driver_impl/src/lib.rs

+    // To avoid confusion, emit warning if no space
+    // between `-o` and arg, e.g.`-optimize`, is applied, see issue #142812
+    if let Some(name) = matches.opt_str("o") {
+        if args.iter().any(|arg| arg.starts_with("-o") && !arg.starts_with("-o=") && arg.ne("-o")) {
+            early_dcx.early_warn(format!("option `-o {}` is applied", name));
+        }
+    }


Suggestion: if we're going to emit this warning, can you also include a bit more context on why this is warned on in the first place and how users can address this warning? I.e. for the wording, I suggest

warning: option `-o` has no space between flag name and value, which can be confusing help: option `-o {}` is applied instead of a flag named `o{}` help: if you meant to specify output filename `{}`, write `-o {}` instead

Suggestion: also, maybe remark this case in the rustc book on compiler flags.

Good suggestions, I will finish this later.

You might want to hold off on changing this for a moment, still discussing formulation of this warning in the linked thread

jieyouxu · 2025-07-10T06:47:15Z

Asking for some more opinions about if warning on -ofilename might be too annoying. Let's give it sometime for the vibecheck, flip this to review / ping me by next thursday (2025-07-17) if we don't have a resolution by then yet.

cf. #t-compiler > Warn on `-ofilename`/`-Lpath` without space

@rustbot label: -S-waiting-on-review +S-waiting-on-team

xizheyin · 2025-07-11T09:53:59Z

Now, it prints like this

$ rustc +stage1 src/main.rs -optimize
warning: option `-o` has no space between flag name and value, which can be confusing

note: option `-o ptimize` is applied instead of a flag named `optimize` to specify output filename `ptimize`

$ rustc +stage1 src/main.rs -out-dir
warning: option `-o` has no space between flag name and value, which can be confusing

note: option `-o ut-dir` is applied instead of a flag named `out-dir` to specify output filename `ut-dir`

note: Do you mean `--out-dir`?

$ rustc +stage1 src/main.rs -overflow-checks
warning: option `-o` has no space between flag name and value, which can be confusing

note: option `-o verflow-checks` is applied instead of a flag named `overflow-checks` to specify output filename `verflow-checks`

note: Do you mean `-C overflow_checks`?

$ rustc +stage1 src/main.rs -overflow_checks
warning: option `-o` has no space between flag name and value, which can be confusing

note: option `-o verflow_checks` is applied instead of a flag named `overflow_checks` to specify output filename `verflow_checks`

note: Do you mean `-C overflow_checks`?

$ rustc +stage1 src/main.rs -o3
warning: option `-o` has no space between flag name and value, which can be confusing

note: option `-o 3` is applied instead of a flag named `o3` to specify output filename `3`

xizheyin

@rustbot ready

jieyouxu

Thanks, some thoughts. Mostly to make this even more conservative.

compiler/rustc_driver_impl/src/lib.rs

compiler/rustc_driver_impl/src/args.rs

jieyouxu · 2025-07-15T02:41:46Z

compiler/rustc_driver_impl/src/args.rs

+    for option in optgroups {
+        let prefix = String::from("--");
+        if starts_with_ignoring_separators(option.long_name(), suspect) {
+            return Some(prefix + option.long_name());
+        }
+    }


Suggestion: I would also not bother with e.g. --oprint

Currently, -oprint won't emit a warning, do you mean we should emit a warning?

Hm, I'm not sure what I meant by this, I meant we should not.

Yes, that's the way it is now. it match oprint which does not exist in rustc option group.

compiler/rustc_driver_impl/src/lib.rs

jieyouxu · 2025-07-15T02:54:13Z

@rustbot author

rustbot · 2025-07-15T02:54:17Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Signed-off-by: xizheyin <[email protected]>

xizheyin · 2025-07-15T09:14:23Z

Done :)

@rustbot ready

jieyouxu

Thanks. We'll have to see if even this ends up too annoying in practice, but IMO this is sufficiently conservative.

jieyouxu · 2025-07-15T09:24:10Z

You can r=me once PR CI is green.
@bors delegate+ rollup

bors · 2025-07-15T09:24:14Z

✌️ @xizheyin, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

xizheyin · 2025-07-15T10:52:15Z

@bors r=@jieyouxu

bors · 2025-07-15T10:52:18Z

📌 Commit 2110bc1 has been approved by jieyouxu

It is now in the queue for this repository.

Emit warning when there is no space between `-o` and arg Closes rust-lang#142812 `getopt` doesn't seem to have an API to check this, so we have to check the args manually. r? compiler

Rollup of 12 pull requests Successful merges: - #142936 (rustdoc-json: Structured attributes) - #143355 (wrapping shift: remove first bitmask and table) - #143448 (remote-test-client: Exit code `128 + <signal-number>` instead of `3`) - #143692 (miri: fix out-of-bounds error for ptrs with negative offsets) - #143719 (Emit warning when there is no space between `-o` and arg) - #143738 (Move several float tests to floats/mod.rs) - #143891 (Port `#[coverage]` to the new attribute system) - #143920 (Make more of codegen_llvm safe) - #143921 (Constify `Index` traits) - #143939 (Add 0323pin as maintainer of NetBSD targets, fix link to pkgsrc-wip and explain.) - #143948 (Update mdbook to 0.4.52) - #143968 (Add tracing to `InterpCx::fn_abi_of_instance/fn_abi_of_fn_ptr`) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned jieyouxu Jul 10, 2025

rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 10, 2025

jieyouxu reviewed Jul 10, 2025

View reviewed changes

tests/run-make/option-output-no-space/rmake.rs Show resolved Hide resolved

rustbot assigned wesleywiser and unassigned jieyouxu Jul 10, 2025

rustbot assigned jieyouxu and unassigned wesleywiser Jul 10, 2025

xizheyin force-pushed the 142812-1 branch from 98e5c53 to 9bacaf7 Compare July 10, 2025 06:29

jieyouxu reviewed Jul 10, 2025

View reviewed changes

rustbot added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2025

xizheyin force-pushed the 142812-1 branch from 9bacaf7 to 0cd9eda Compare July 11, 2025 09:49

xizheyin commented Jul 11, 2025

View reviewed changes

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 11, 2025

xizheyin force-pushed the 142812-1 branch from 0cd9eda to 1b0bb49 Compare July 11, 2025 10:17

jieyouxu removed the S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). label Jul 12, 2025

jieyouxu reviewed Jul 15, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2025

xizheyin force-pushed the 142812-1 branch from 1b0bb49 to afea9de Compare July 15, 2025 08:27

Emit warning when there is no space between -o and confusing arg

2110bc1

Signed-off-by: xizheyin <[email protected]>

xizheyin force-pushed the 142812-1 branch from afea9de to 2110bc1 Compare July 15, 2025 09:14

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 15, 2025

jieyouxu approved these changes Jul 15, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2025

samueltardieu mentioned this pull request Jul 15, 2025

Rollup of 12 pull requests #143974

Closed

samueltardieu mentioned this pull request Jul 15, 2025

Rollup of 11 pull requests #143976

Closed

samueltardieu mentioned this pull request Jul 15, 2025

Rollup of 11 pull requests #143978

Closed

samueltardieu mentioned this pull request Jul 15, 2025

Rollup of 10 pull requests #143982

Closed

samueltardieu mentioned this pull request Jul 15, 2025

Rollup of 12 pull requests #143983

Open

Emit warning when there is no space between -o and arg #143719

Are you sure you want to change the base?

Emit warning when there is no space between -o and arg #143719

Conversation

xizheyin commented Jul 10, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 10, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jieyouxu commented Jul 10, 2025

Uh oh!

rustbot commented Jul 10, 2025

Uh oh!

jieyouxu commented Jul 10, 2025

Uh oh!

jieyouxu Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

jieyouxu Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

xizheyin Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

jieyouxu Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xizheyin commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xizheyin left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jieyouxu Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

xizheyin Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

jieyouxu Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

xizheyin Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jieyouxu commented Jul 15, 2025

Uh oh!

rustbot commented Jul 15, 2025

Uh oh!

xizheyin commented Jul 15, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Jul 15, 2025

Uh oh!

bors commented Jul 15, 2025

Uh oh!

xizheyin commented Jul 15, 2025

Uh oh!

Emit warning when there is no space between `-o` and arg #143719

Emit warning when there is no space between `-o` and arg #143719

xizheyin commented Jul 10, 2025 •

edited by rustbot

Loading

jieyouxu Jul 10, 2025 •

edited

Loading

jieyouxu commented Jul 10, 2025 •

edited

Loading

xizheyin commented Jul 11, 2025 •

edited

Loading