Retire hir::*ItemRef. #143357

cjgillot · 2025-07-03T09:36:05Z

This information was kept for various places that iterate on HIR to know about trait-items and impl-items.

This PR replaces them by uses of the associated_items query that contain pretty much the same information.

This shortens many spans to just def_span, which can be easier to read.

cjgillot · 2025-07-03T11:04:15Z

@bors try @rust-timer queue

bors · 2025-07-03T11:05:26Z

⌛ Trying commit 4e5d3e2 with merge 2d047d1...

Retire hir::*ItemRef. r? `@ghost` for perf

bors · 2025-07-03T13:20:25Z

☀️ Try build successful - checks-actions
Build commit: 2d047d1 (2d047d1af1d10ea3b11563dc0347bfc68cf188e9)

bors · 2025-07-04T00:21:44Z

☔ The latest upstream changes (presumably #143390) made this pull request unmergeable. Please resolve the merge conflicts.

rust-timer · 2025-07-04T03:27:38Z

Finished benchmarking commit (2d047d1): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.1%, 0.2%]	4
Regressions ❌ (secondary)	0.5%	[0.2%, 0.7%]	11
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.1%	[-11.6%, -0.2%]	13
All ❌✅ (primary)	0.2%	[0.1%, 0.2%]	4

Max RSS (memory usage)

Results (primary 0.7%, secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.8%, 2.0%]	2
Regressions ❌ (secondary)	0.9%	[0.9%, 0.9%]	1
Improvements ✅ (primary)	-1.6%	[-1.6%, -1.6%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.7%	[-1.6%, 2.0%]	3

Cycles

Results (secondary -4.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.1%	[4.1%, 4.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-6.0%	[-8.2%, -3.0%]	8
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 461.527s -> 461.455s (-0.02%)
Artifact size: 372.16 MiB -> 372.04 MiB (-0.03%)

rustbot · 2025-07-04T09:53:32Z

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-07-04T09:53:34Z

Changes to the size of AST and/or HIR nodes.

cc @nnethercote

changes to the core type system

cc @compiler-errors, @lcnr

Some changes occurred in match checking

cc @Nadrieril

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

bors · 2025-07-13T02:16:32Z

☔ The latest upstream changes (presumably #143783) made this pull request unmergeable. Please resolve the merge conflicts.

compiler-errors

LGTM. Some naming questions, but perhaps best saved for a follow-up.

compiler-errors · 2025-07-13T18:53:06Z

compiler/rustc_ast_lowering/src/index.rs

-        let TraitItemRef { id, ident: _, kind: _, span: _ } = *ii;
-
-        self.visit_nested_trait_item(id);
+    fn visit_trait_item_ref(&mut self, id: &'hir TraitItemId) {


Why is it still called visit_trait_item_ref? Should we give this a better name?

compiler-errors · 2025-07-13T18:53:30Z

compiler/rustc_ast_lowering/src/item.rs

-            ident: self.lower_ident(i.kind.ident().unwrap()),
-            span: self.lower_span(i.span),
-        }
+    fn lower_foreign_item_ref(&mut self, i: &ForeignItem) -> hir::ForeignItemId {


Likewise naming

compiler-errors · 2025-07-13T18:56:14Z

r? compiler-errors @bors r+

bors · 2025-07-13T18:56:16Z

📌 Commit 27127e3 has been approved by compiler-errors

It is now in the queue for this repository.

bors · 2025-07-13T22:39:14Z

⌛ Testing commit 27127e3 with merge 9c3064e...

bors · 2025-07-14T01:45:11Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 9c3064e to master...

github-actions · 2025-07-14T01:47:55Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e9182f1 (parent) -> 9c3064e (this PR)

Test differences

Show 40 test diffs

40 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 9c3064e131f4939cc95a29bb11413c49bbda1491 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-2: 3156.9s -> 4214.5s (33.5%)
dist-aarch64-linux: 6326.0s -> 8137.9s (28.6%)
dist-x86_64-apple: 7755.2s -> 9338.3s (20.4%)
pr-check-2: 2211.0s -> 2645.0s (19.6%)
aarch64-apple: 4095.4s -> 4724.2s (15.4%)
aarch64-gnu-debug: 3670.8s -> 4199.5s (14.4%)
x86_64-gnu-tools: 3220.7s -> 3674.2s (14.1%)
i686-gnu-2: 5526.6s -> 6270.8s (13.5%)
x86_64-gnu-llvm-19-1: 3305.9s -> 3717.5s (12.5%)
i686-gnu-1: 7197.3s -> 8081.1s (12.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-07-14T03:01:37Z

Finished benchmarking commit (9c3064e): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	1
Regressions ❌ (secondary)	0.3%	[0.2%, 0.3%]	6
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.1%]	1
Improvements ✅ (secondary)	-4.8%	[-11.6%, -0.2%]	14
All ❌✅ (primary)	0.0%	[-0.1%, 0.2%]	2

Max RSS (memory usage)

Results (primary 1.5%, secondary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.5%	[1.5%, 1.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.5%	[-2.5%, -2.5%]	1
All ❌✅ (primary)	1.5%	[1.5%, 1.5%]	1

Cycles

Results (secondary -4.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	8.2%	[8.2%, 8.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-6.9%	[-8.7%, -4.7%]	6
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 464.056s -> 462.57s (-0.32%)
Artifact size: 374.70 MiB -> 374.65 MiB (-0.01%)

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 3, 2025

cjgillot force-pushed the no-assoc-item-kind branch from 1264eb5 to 4e5d3e2 Compare July 3, 2025 11:03

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 3, 2025

bors added a commit that referenced this pull request Jul 3, 2025

Auto merge of #143357 - cjgillot:no-assoc-item-kind, r=<try>

2d047d1

Retire hir::*ItemRef. r? `@ghost` for perf

This comment has been minimized.

Sign in to view

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 4, 2025

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 4, 2025

cjgillot marked this pull request as ready for review July 4, 2025 09:53

rustbot assigned SparrowLii Jul 4, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 4, 2025

cjgillot force-pushed the no-assoc-item-kind branch from 643804d to 8063b5b Compare July 4, 2025 10:52

cjgillot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 5, 2025

cjgillot force-pushed the no-assoc-item-kind branch from 8063b5b to 65a5f88 Compare July 13, 2025 13:49

rustbot added the T-clippy Relevant to the Clippy team. label Jul 13, 2025

cjgillot added 3 commits July 13, 2025 13:50

Remove usused depth.

ad6e587

Delegation: self parameter must be named exactly self.

50ca0c6

Move trait_item_def_id from ImplItemRef to ImplItem.

3ecd03b

cjgillot added 5 commits July 13, 2025 13:50

Remove hir::AssocItemKind.

277b0ec

Generalize TyCtxt::item_name.

36bc094

Retire hir::ForeignItemRef.

5bd3841

Retire hir::*ItemRef.

21fd82a

Bless incremental tests.

27127e3

cjgillot force-pushed the no-assoc-item-kind branch from 65a5f88 to 27127e3 Compare July 13, 2025 13:50

compiler-errors approved these changes Jul 13, 2025

View reviewed changes

rustbot assigned compiler-errors and unassigned SparrowLii Jul 13, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 14, 2025

bors merged commit 9c3064e into rust-lang:master Jul 14, 2025
12 checks passed

rustbot added this to the 1.90.0 milestone Jul 14, 2025

This was referenced Jul 14, 2025

Explicitly export core and std macros #139493

Open

[Draft] Supertrait item resolution in subtrait impls #143527

Draft

cjgillot deleted the no-assoc-item-kind branch July 14, 2025 05:11

Retire hir::*ItemRef. #143357

Retire hir::*ItemRef. #143357

Conversation

cjgillot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjgillot commented Jul 3, 2025

Uh oh!

This comment has been minimized.

bors commented Jul 3, 2025

Uh oh!

This comment has been minimized.

bors commented Jul 3, 2025

Uh oh!

This comment has been minimized.

bors commented Jul 4, 2025

Uh oh!

rust-timer commented Jul 4, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

rustbot commented Jul 4, 2025

Uh oh!

rustbot commented Jul 4, 2025

Uh oh!

bors commented Jul 13, 2025

Uh oh!

compiler-errors left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

compiler-errors commented Jul 13, 2025

Uh oh!

bors commented Jul 13, 2025

Uh oh!

bors commented Jul 13, 2025

Uh oh!

bors commented Jul 14, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 14, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Jul 14, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

Uh oh!

cjgillot commented Jul 3, 2025 •

edited

Loading