Pass FnAbi to find_mir_or_eval_fn #133103
Open
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the CTFE machinery cc @rust-lang/wg-const-eval Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri The Miri subtree was changed cc @rust-lang/miri |
RalfJung
reviewed
Nov 24, 2024
| @@ -202,6 +203,7 @@ pub trait Machine<'tcx>: Sized { | |||
| ecx: &mut InterpCx<'tcx, Self>, | |||
| instance: ty::Instance<'tcx>, | |||
| abi: ExternAbi, | |||
| _fnabi: &FnAbi<'tcx, Ty<'tcx>>, | |||
There was a problem hiding this comment.
As discussed in the Miri issue, IMO this should replace the ExternAbi argument, not complement it.
There was a problem hiding this comment.
If we remove the ExternAbi here, we need to change how we handle check_abi_and_shim_symbol_clash in this PR too. I initially thought of splitting it into two pr:
- Pass down
FnAbi - Handle
check_abi_and_shim_symbol_clashand remove all unusedExternAbi.
But if this is preferred, I can do them in a single pr.
There was a problem hiding this comment.
I'd like to avoid growing the number of arguments, so yeah I figured this would be one PR.
|
@rustbot author |
rustbot
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/miri#4013 needs information from
FnAbi, hence it is passed tofind_mir_or_eval_fn.r? @RalfJung