Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore errors in Drop for unix::fs::Dir #124107

Closed
wants to merge 1 commit into from

Conversation

ConradIrwin
Copy link

Fixes #124105

@rustbot
Copy link
Collaborator

rustbot commented Apr 18, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joboet (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 18, 2024
@the8472
Copy link
Member

the8472 commented Apr 18, 2024

I'm opposing this change due to #124105 (comment)

@the8472
Copy link
Member

the8472 commented Apr 19, 2024

Since FUSE can inject EBADF into close() syscalls - which is ugly but non-fatal - I retract my opposition.

@bors
Copy link
Contributor

bors commented Apr 28, 2024

☔ The latest upstream changes (presumably #124210) made this pull request unmergeable. Please resolve the merge conflicts.

@ConradIrwin
Copy link
Author

Closing this. Will re-open if/when I can get some more conclusive results from testing.

@ConradIrwin ConradIrwin closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: unexpected error during closedir "Bad file descriptor" for unix::fs::Dir
5 participants