Handle non-adjacent boolean arms in match_like_matches_macro

[fzlzjerry]

changelog: [match_like_matches_macro]: lint boolean matches with non-adjacent equal-result arms

Fixes #17616

Summary

• group guard-free boolean-literal arms by their result instead of requiring one identical-result prefix
• keep wildcard patterns out of the suggestion by selecting the opposite result group
• preserve match-arm precedence by bailing when a selected pattern overlaps an earlier arm with the opposite result
• share pattern normalization and overlap analysis through the matches::pat_overlap utility
• cover T-F-T matches, mixed wildcard fallbacks, overlapping patterns, and uniform-result matches
• update Clippy's dogfood matches exposed by the broader lint

Validation

• TESTNAME=match_like_matches_macro cargo uitest
• TESTNAME=match_same_arms cargo uitest
• cargo test --test dogfood
• cargo dev fmt --check
• cargo test

Related work

#17505 independently fixes binding redaction in combined or-pattern suggestions and touches the same suggestion builder. This branch leaves that work there and can be rebased after it lands.

[rustbot]

Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews.

In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[github-actions]

Lintcheck changes for dc93a16

Lint	Added	Removed	Changed
clippy::match_like_matches_macro	7	0	0
clippy::match_same_arms	0	9	1

This comment will be updated if you push new changes

[CommanderStorm]

I think this mostly looks good, but there are a lot of changes and honestly there might be gaps.

View changes since this review

[CommanderStorm]

Community review: LGTM.
I would ask you to squash the commits down to the appropriate amount, so likely 2 (the pat_overlap and the actual lint+test change)

View changes since this review

[fzlzjerry]

Rewrote the branch history into the two requested logical commits:

• 034e59ca0 extracts the normalized-pattern overlap analysis into matches::pat_overlap
• dc93a16fa contains the lint behavior, regression coverage, and dogfood updates

The resulting tree is identical to the approved adb475e9b tree. I also verified the extraction commit independently with the 8 match_same_arms UI cases, then reran formatting and the 3 match_like_matches_macro UI cases on the final head; the prior dogfood and full cargo test run applies to the byte-identical final tree.