Prepare to turn clippy into a workspace - #17572
Conversation
rustbot
added
S-waiting-on-community-reviews
|
Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews. In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
|
|
||
| // FIXME: switch to something more ergonomic here, once available. | ||
| // (Currently there is no way to opt into sysroot crates without `extern crate`.) | ||
| extern crate rustc_driver; |
There was a problem hiding this comment.
That's a thing that will never be fixed, so it's not very helpful to have a note for it.
| @@ -1,5 +1,3 @@ | |||
| // We need this feature as it changes `dylib` linking behavior and allows us to link to | |||
| // `rustc_driver`. | |||
| #![feature(rustc_private)] | |||
There was a problem hiding this comment.
I would find the dylib not very obvious.. you sure?
There was a problem hiding this comment.
The feature doesn't change linking behaviour. Importing rustc_driver is what links to the dylib.
|
☔ The latest upstream changes (possibly #17607) made this pull request unmergeable. Please resolve the merge conflicts. |
3 participants
Mostly changes that need to happen to move clippy to a workspace. The
FIXMEfor theextern crateblock is also removed since we aren't going to get an alternative solution.changelog: none