Fix lints duplications in unknown_attribute and renamed_builtin_attr#17164
Open
Gri-ffin wants to merge 1 commit into
Open
Fix lints duplications in unknown_attribute and renamed_builtin_attr#17164Gri-ffin wants to merge 1 commit into
unknown_attribute and renamed_builtin_attr#17164Gri-ffin wants to merge 1 commit into
Conversation
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @llogiq rustbot has assigned @llogiq. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
remove Zdeduplicate-diagnostics flag remove unused sess from `get_builtin_attr` move checking to lint early pass Fix duplicate diagnostics for `unknown_attribute` and `renamed_builtin_attr`
Gri-ffin
force-pushed
the
dedup-clippy-attributes
branch
from
641bbc6 to
f69a253
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #12379
I moved the linting logic from
get_builtin_attrinto a dedicatedcheck_clippy_attrfunction called once per attribute during
EarlyLintPass.Initially I've put it in
LateLintPassbut the early pass seemed like the more appropriate place?changelog: fix duplicate diagnostics in
unknown_attributeandrenamed_builtin_attr