Fix branches-sharing-code suggests wrongly on const and static
#15522
+388
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rustbot
added
the
S-waiting-on-review
|
Lintcheck changes for f83c72f
This comment will be updated if you push new changes |
profetia
force-pushed
the
issue15347
branch
2 times, most recently
from
8fbd252 to
c1f05aa
Compare
ada4a
reviewed
Aug 21, 2025
Contributor
Author
|
r? clippy |
Contributor
Author
|
r? clippy |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
r? clippy |
Contributor
Author
|
r? clippy |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
r? clippy |
blyxyas
requested changes
Nov 26, 2025
| } | ||
| }, | ||
| (ItemKind::Mod(l_ident, l_mod), ItemKind::Mod(r_ident, r_mod)) => { | ||
| l_ident.name == r_ident.name && over(l_mod.item_ids, r_mod.item_ids, |l, r| self.eq_item(*l, *r)) |
Member
There was a problem hiding this comment.
I know that it's technically outside the scope of the PR, but could you change the eq_fn on over to be is_equal? Having the nomenclature for a closure be equal to the existing eq_fn_sig, eq_fn_decl is a bit confusing...
Contributor
Author
There was a problem hiding this comment.
Umm, what is_equal?
rustbot
removed
the
S-waiting-on-review
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
rustbot
added
the
S-waiting-on-author
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15347
changelog: [
branches-sharing-code] fix wrong suggestions onconstandstatic