new lint: unnecessary_reserve
#14114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
wowinter13
changed the title
unnecessary_reserve
samueltardieu
suggested changes
Jan 30, 2025
|
@samueltardieu Samuel, really appreciate your review and points! |
| vec.reserve(array1.len()); | ||
| vec.extend(array2); | ||
|
|
||
| // do not lint |
There was a problem hiding this comment.
Why not? Or it can be done in a later PR.
| vec.reserve(1); | ||
| vec.extend([1]); | ||
|
|
||
| //// do lint |
There was a problem hiding this comment.
You should use error markers to check that the lint is correctly emitted (a comment starting with //~).
| } | ||
|
|
||
| fn msrv_1_62() { | ||
| #![clippy::msrv = "1.61"] |
There was a problem hiding this comment.
It is unusual to:
- apply an attribute from the inside of a function
- name a function
msrv_1_62and apply it aclippy::msrv = "1.61"attribute
Maybe call the function insufficient_msrv and apply the attribute to it.
| let array2: &[usize] = &[3, 4]; | ||
|
|
||
| // do not lint - different arrays | ||
| ; |
There was a problem hiding this comment.
The ";" should be removed as well. When you find the reserve(), you might want to look for the parent statement to get the span.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resurrection of #10157
fixes #8982
changelog: [
unnecessary_reserve]: add new lint unnecessary_reserve