Skip to content

exclude some directories from Lintcheck CI #14084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

lapla-cogito
Copy link
Contributor

@lapla-cogito lapla-cogito commented Jan 27, 2025

Currently, the CI pipeline triggers Lintcheck for all PRs. However, this check takes significant amount of time and seems unnecessary for some certain directories that are frequently updated.

r? flip1995

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 27, 2025
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea for lintcheck, sadly doesn't work for clippy_dev and other workflows. We did that before moving to merge queue.

@lapla-cogito lapla-cogito requested a review from flip1995 January 27, 2025 22:16
@lapla-cogito lapla-cogito changed the title exclude some directories from Lintcheck and Dev Test CI exclude some directories from Lintcheck CI Jan 27, 2025
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@flip1995 flip1995 added this pull request to the merge queue Jan 28, 2025
Merged via the queue into rust-lang:master with commit 25509e7 Jan 28, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants