new lint: unnecessary_indexing
#14058
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not lint after mutable reference is taken check path to local on conditional receiver, check mutable borrow after ref, do not lint on mutable auto borrow fix autoborrow/mutability checks remove unneded `extra_locals` inline if ststements; check locality earlier remove unnecessary impl on IndexCheckResult check for borrows in if block and change inner `Some` based on this
…f condition & lint messages etc.
rustbot
added
the
S-waiting-on-review
| /// Use instead: | ||
| /// ```no_run | ||
| /// let a: &[i32] = &[1]; | ||
| /// if let Some(b) = a.first() { |
There was a problem hiding this comment.
Note that you can generate even simplier expressions:
- If
ais a slice ref, use:if let [b, ..] = a - If
ais an array, use:if let [b, ..] = &a - If
aderefs to a slice, use:if let [b, ..] = &a[..]
There was a problem hiding this comment.
I can add it as an alternate suggestion, which one is more preferable though?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #11858
This is a continuation of #12464 (shout out to @Jacherr for their hard work)
Since they don't have time, I thought I could push this forward by adding another commit on top of it to fix some of the addressed issues.
r? Alexendoo
changelog: add new lint [
unnecessary_indexing]