Fix expand/collapse all on site, make highlightjs lazier #14038
Merged
+81
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Alexendoo
force-pushed
the
site-expand-collapse
branch
from
84dcb9a to
bb746e1
Compare
|
ty for this :D just tried to use expand all button at https://rust-lang.github.io/rust-clippy/master/index.html but can't :( |
blyxyas
requested changes
Jan 28, 2025
| document.getElementById("expand-all").addEventListener("click", () => toggleExpansion(true)); | ||
| document.getElementById("collapse-all").addEventListener("click", () => toggleExpansion(false)); | ||
|
|
||
| document.addEventListener("click", event => { |
There was a problem hiding this comment.
This could be more consistent with the code above it if we just used document.getElementsByClassName. it does exactly what the code looks for, but in a built-in method.
There was a problem hiding this comment.
This bit is using event delegation in order to avoid adding ~1500 listeners
Maybe not a noticeable difference but it shaves off a few ms
| if (!'IntersectionObserver' in window) { | ||
| return; | ||
| } | ||
| const observer = new IntersectionObserver((entries) => { |
Alexendoo
force-pushed
the
site-expand-collapse
branch
from
bb746e1 to
33bb8af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the buttons that expand/collapse all the lints in the list, it also makes code block syntax highlighting only happen when the specific lint enters the viewport since highlighting them all at once was fairly heavy
There's also a few miscellaneous inline event handler removals
script.jsand highlightjs are now loaded withdeferso that the download can start earlierAlso fixes #14048, we were calling highlight on the
prein<pre><code>...</code></pre>but highlightjs wants us to call it on thecodeelementchangelog: none