Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[path_buf_push_overwrite]: mark suggestion as MaybeIncorrect #14010

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

samueltardieu
Copy link
Contributor

@samueltardieu samueltardieu commented Jan 16, 2025

Proposing to replace

let mut x = PathBuf::from("/foo");
x.push("/bar");

by

let mut x = PathBuf::from("/foo");
x.push("bar");

changes the content of x (/bar/foo/bar). This is not equivalent and should not be MachineApplicable, even if the original code is suspicious.

changelog: none

Proposing to replace

```rust
let mut x = PathBuf::from("/foo");
x.push("/bar");
```

by

```rust
let mut x = PathBuf::from("/foo");
x.push("bar");
```

changes the content of `x` (`/bar` ⇒ `/foo/bar`).
@rustbot
Copy link
Collaborator

rustbot commented Jan 16, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 16, 2025
@samueltardieu
Copy link
Contributor Author

r? @Clippy

@rustbot rustbot assigned Centri3 and unassigned Jarcho Jan 31, 2025
@Centri3 Centri3 added this pull request to the merge queue Feb 7, 2025
Merged via the queue into rust-lang:master with commit b5ea249 Feb 7, 2025
13 checks passed
@samueltardieu samueltardieu deleted the push-vlkvosvumvlk branch February 7, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants