fix: manual_unwrap_or_default suggests falsely when condition type is uncertain
#13889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Jarcho (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
the
S-waiting-on-review
profetia
force-pushed
the
issue12670
branch
2 times, most recently
from
ca507e7 to
e6044a5
Compare
|
r? clippy |
llogiq
reviewed
Feb 4, 2025
| MANUAL_UNWRAP_OR_DEFAULT, | ||
| expr.span, | ||
| format!("{expr_name} can be simplified with `.unwrap_or_default()`"), | ||
| format!("explicit the type {expr_type} and replace your expression with"), |
There was a problem hiding this comment.
Suggested change
| format!("explicit the type {expr_type} and replace your expression with"), | |
| format!("ascribe the type {expr_type} and replace your expression with"), |
Or we could maybe even do a multispan suggestion using a empty span at the end of the let pattern, to be replaced with the type.
|
Can you squash your commits, please? |
squashed |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12670
Continuation of #12688. r? @Jarcho if you don't mind?
changelog: [
manual_unwrap_or_default] fix wrong suggestions when condition type is uncertain