extend unchecked_duration_subtraction to check for Duration - Duration
#13800
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dswij (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
the
S-waiting-on-review
| @@ -139,16 +142,23 @@ fn print_unchecked_duration_subtraction_sugg( | |||
| expr: &Expr<'_>, | |||
| ) { | |||
| let mut applicability = Applicability::MachineApplicable; | |||
| let ty = cx.typeck_results().expr_ty(expr).peel_refs(); | |||
| let (left_default, left_ty) = match ty::get_type_diagnostic_name(cx, ty) { | |||
| Some(v) => (format!("<{}>", v.as_str().to_lowercase()), v.as_str().to_string()), | |||
There was a problem hiding this comment.
unsure if this is needed (the 'default'), thoughts? any better way to handle?
|
@sharksforarms |
Duration - Duration could panic in the same way as Instant - Duration
sharksforarms
force-pushed
the
sharksforarms/duration-sub
branch
from
722aad6 to
59a03d7
Compare
|
@alex-semenyuk ah! thanks. forgot to rerun uibless. I rebased. |
| @@ -41,7 +41,7 @@ declare_clippy_lint! { | |||
|
|
|||
There was a problem hiding this comment.
While we're at it, can we also rename the struct (and the file) from InstantSubstraction?
Seems like it won't give the right idea after the changes.
| @@ -3,14 +3,21 @@ | |||
| use std::time::{Duration, Instant}; | |||
There was a problem hiding this comment.
Can we also add some test cases for Duration - Duration - Duration and see if the fixes are correct?
fixes #13734
This PR extends the
unchecked_duration_subtractionlint to includeDuration - Durationoperations. Previously, it was onlyInstant - Duration.Duration - Durationis a common operation which may panic in the same way.Note: This is my first clippy PR, feedback is appreciated.
changelog: [
unchecked_duration_subtraction]: extend lint to include subtraction of aDurationwith aDuration