Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select Rust edition 2024 for compiling Clippy #13751

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samueltardieu
Copy link
Contributor

@samueltardieu samueltardieu commented Nov 29, 2024

The Cargo feature is no longer experimental and is enabled by default in our nightly compiler.

changelog: Clippy now uses Rust edition 2024

@rustbot
Copy link
Collaborator

rustbot commented Nov 29, 2024

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 29, 2024
@samueltardieu
Copy link
Contributor Author

r? @flip1995

@rustbot rustbot assigned flip1995 and unassigned dswij Nov 29, 2024
@samueltardieu samueltardieu mentioned this pull request Nov 29, 2024
4 tasks
@samueltardieu
Copy link
Contributor Author

The compiler sources still use edition 2021. However, even though the Clippy sources are synced back into the rust-lang repo, I think this would cause no bootstrapping issues as Clippy is always built with the newly built compiler.

@flip1995
Copy link
Member

I'll take a closer look at the edition update during the Christmas holidays. Should be good to go, I just want to take the time so that I didn't miss anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants