Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use assert_eq! and _ne!, remove uneeded parens #3082

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Jan 9, 2025

  • convert assert! to assert_eq! and assert_ne! where possible
  • remove unneeded parenthesis

@@ -804,7 +804,7 @@ If you encounter an error missing from this list, please file an issue or a PR!"
self.current_module
);

self.items[(self.current_module.0).0]
self.items[self.current_module.0 .0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks drive-by but alright.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, i forgot to include it in the description - i actually fixed a number of these too as part of this PR. Updated.

@emilio emilio added this pull request to the merge queue Jan 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2025
@nyurik nyurik changed the title use assert_eq|_ne instead of assert! use assert_eq! and _ne!, remove uneeded parens Jan 10, 2025
@emilio emilio added this pull request to the merge queue Feb 1, 2025
Merged via the queue into rust-lang:main with commit 9ce9a1c Feb 1, 2025
34 checks passed
@nyurik nyurik deleted the assert branch February 1, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants