Add support for tid argument in sched_(get/set)affinity #4130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
Jan 11, 2025
| // TODO: when https://github.com/rust-lang/miri/issues/3730 is fixed this should use its notion of tid/pid | ||
| let thread_id = match pid { | ||
| 0 => this.active_thread(), | ||
| let thread_id = match (pid, &*this.tcx.sess.target.os) { |
There was a problem hiding this comment.
Seems a bit odd to match on the pair here. I think this is more clear as
if pid == 0 { ... }
else if this.tcx.sess.target.os == "linux" {
// On Linux we support `gettid`, which is guaranteed to support IDs matching `sched_getaffinity`.
...
} else { ... }
RalfJung
reviewed
Jan 11, 2025
| let thread_id = match (pid, &*this.tcx.sess.target.os) { | ||
| (0, _) => this.active_thread(), | ||
| (tid, "linux") => { | ||
| if let Ok(tid) = this.machine.threads.thread_id_try_from(tid) { |
There was a problem hiding this comment.
This will not return the right ID. See the gettid implementation to see how ThreadId is converted to the user-visible TID; this here will have to do the opposite transformation. Please put both directions in some shared place to make sure they remain consistent in the future.
RalfJung
requested changes
Jan 11, 2025
|
☔ The latest upstream changes (possibly 1c87fa0) made this pull request unmergeable. Please resolve the merge conflicts. |
rustbot
added
the
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to #4062
On Linux, values returned by
gettidcan be passed as thepidargument when callingsched_getaffinityorsched_setaffinity.