Skip to content

fix toolchain flag parsing #4113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2024
Merged

fix toolchain flag parsing #4113

merged 1 commit into from
Dec 28, 2024

Conversation

@rmehri01
Copy link
Contributor

@rmehri01 rmehri01 commented Dec 28, 2024 •
edited
Loading

I think this one was missed in #4036, I was getting the following when trying ./miri toolchain -c rust-analyzer:

error: unexpected argument '-c' found

  tip: to pass '-c' as a value, use '-- -c'

Usage: miri-script toolchain [FLAGS]...

For more information, try '--help'.

@RalfJung
Copy link
Member

RalfJung commented Dec 28, 2024

Good catch, thanks!

@RalfJung RalfJung added this pull request to the merge queue Dec 28, 2024
Merged via the queue into rust-lang:master with commit d9396fe Dec 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rmehri01 @RalfJung