Replace time crate with jiff #15293
Draft
Replace time crate with jiff #15293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-configuration
|
r? @epage |
BurntSushi
reviewed
Mar 10, 2025
| @@ -619,7 +620,7 @@ fn auth_token_optional( | |||
| if let Some(cached_token) = cache.get(url) { | |||
| if cached_token | |||
| .expiration | |||
| .map(|exp| OffsetDateTime::now_utc() + Duration::minutes(1) < exp) | |||
| .map(|exp| Timestamp::now() + Duration::from_secs(60) < exp) | |||
There was a problem hiding this comment.
Small thing, but you could do Timestamp::now() + SignedDuration::from_mins(1) here.
BurntSushi
reviewed
Mar 11, 2025
| @@ -367,7 +367,6 @@ dependencies = [ | |||
| "tar", | |||
| "tempfile", | |||
| "thiserror 2.0.11", | |||
| "time", | |||
There was a problem hiding this comment.
Unfortunately it looks like this PR doesn't actually remove time from the dependency tree. As far as I can tell, it's still being brought in by pasetors.
It looks like it's primarily used by Cargo, so maybe they'd be open to a switch as well.
There was a problem hiding this comment.
Thanks for highlighting this.
To be clear, this wouldn't be a blocker for this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #15290 replaced
humantimecrate withjiffand this PR replacestimecrate in favor ofjiff.This should not have functional change.