added the third_party_subcommands function in the cli.rs file

[ibilalkayy]

Hey there,

After grinding for hours, I think I found a place to call the third_party_subcommands function in the cli.rs file and after putting third_party return value inside the CodeCompletion::new(), it gave me the following error:

the trait bound `OsString: From<BTreeMap<std::string::String, cargo::util::command_prelude::CommandInfo>>` is not satisfied
the following other types implement trait `From<T>`:
  `OsString` implements `From<&T>`
  `OsString` implements `From<Box<std::ffi::OsStr>>`
  `OsString` implements `From<Cow<'_, std::ffi::OsStr>>`
  `OsString` implements `From<PathBuf>`
  `OsString` implements `From<clap::builder::OsStr>`
  `OsString` implements `From<clap::builder::Str>`
  `OsString` implements `From<std::string::String>`
required for `BTreeMap<std::string::String, cargo::util::command_prelude::CommandInfo>` to implement `Into<OsString>`rustc[Click for full compiler diagnostic](rust-analyzer-diagnostics-view:/diagnostic%20message%20[0]?0#file:///home/ibilalkayy/Documents/cargo/src/bin/cargo/cli.rs)
cli.rs(586, 18): required by a bound introduced by this call
candidate.rs(19, 28): required by a bound in `CompletionCandidate::new`

After going to the candidate.rs file (that is not present in the cargo repo as I looked through it), I noticed that another fields needs to be added to be implemented in a method that will take arguments and then pass on.

Let me know if I am on the right track and if further improvements need to be added.

Thank you!

[rustbot]

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[ibilalkayy]

r? @epage

[weihanglo]

While I guess this may come from office hours, could you please link to the original issue, and write a clear description of what this is going to resolve? We have a PR template, if you are unsure how to write a proper description.

[ibilalkayy]

Thank you, @weihanglo for sharing the PR template!

I am trying to implement the feature for adding third-party subcommands. Here is the tracking issue where two of my PRs were merged relevant to the third-party subcommands and aliases but now I need to call them and during the call in the cli.rs file, this is where I faced the issues that I mentioned in the description.

I will be discussing this later on with Ed Page during an office hour.

[epage]

The closure returns a Vec of all subcommand candidates. This tries to pass all third-party subcommands as a single candidate.

Also, when sharing incomplete code like this either open it as a Draft or just push your branch and share that.