-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(publish): Downgrade version-exists error to warning on dry-run #14742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will get cherry-picked to beta Fixes rust-lang#14721
rustbot
added
A-interacts-with-crates.io
Area: interaction with registries
Command-publish
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 29, 2024
Thanks! @bors r+ |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 29, 2024
☀️ Test successful - checks-actions |
1 similar comment
☀️ Test successful - checks-actions |
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
bors
added a commit
that referenced
this pull request
Oct 29, 2024
[beta-1.83] fix(publish): Downgrade version-exists error to warning on dry-run Beta backports * #14742 In order to make CI pass, the following PRs are also cherry-picked: *
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-interacts-with-crates.io
Area: interaction with registries
Command-publish
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Especially for beta, this was the most conservative, minimal change.
Fixes #14721
How should we test and review this PR?
Additional information
This will get cherry-picked to beta