Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): Downgrade version-exists error to warning on dry-run #14742

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

epage
Copy link
Contributor

@epage epage commented Oct 29, 2024

What does this PR try to resolve?

Especially for beta, this was the most conservative, minimal change.

Fixes #14721

How should we test and review this PR?

Additional information

This will get cherry-picked to beta

@rustbot
Copy link
Collaborator

rustbot commented Oct 29, 2024

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-interacts-with-crates.io Area: interaction with registries Command-publish S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2024
@ehuss
Copy link
Contributor

ehuss commented Oct 29, 2024

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 29, 2024

📌 Commit 947e1ff has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2024
@bors
Copy link
Collaborator

bors commented Oct 29, 2024

⌛ Testing commit 947e1ff with merge 92f94a5...

@bors
Copy link
Collaborator

bors commented Oct 29, 2024

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 92f94a5 to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Oct 29, 2024

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 92f94a5 to master...

@bors bors merged commit 92f94a5 into rust-lang:master Oct 29, 2024
22 checks passed
@bors
Copy link
Collaborator

bors commented Oct 29, 2024

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

@epage epage deleted the publish branch October 29, 2024 16:57
bors added a commit that referenced this pull request Oct 29, 2024
[beta-1.83] fix(publish): Downgrade version-exists error to warning on dry-run

Beta backports

* #14742

In order to make CI pass, the following PRs are also cherry-picked:

*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-interacts-with-crates.io Area: interaction with registries Command-publish S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot dry-run cargo publish without bumping versions
4 participants