Add ability to set priority grouping. #431
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @adamgreig (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
S-waiting-on-review
reitermarkus
commented
Apr 21, 2022
src/peripheral/scb.rs
Outdated
| }; | ||
| crate::asm::dsb(); | ||
| loop { | ||
| // wait for the reset | ||
| crate::asm::nop(); // avoid rust-lang/rust#28728 | ||
| } | ||
| } | ||
|
|
||
| /// Set the priority grouping. | ||
| pub fn set_priority_grouping(&mut self, grouping: PriorityGrouping) { |
There was a problem hiding this comment.
Not sure if this is safe or whether it should be an unsafe fn.
reitermarkus
force-pushed
the
priority-grouping
branch
4 times, most recently
from
20d4477
to
90b44f4
Compare
reitermarkus
force-pushed
the
priority-grouping
branch
2 times, most recently
from
d5b3579
to
6347d07
Compare
reitermarkus
force-pushed
the
priority-grouping
branch
from
6347d07
to
208b0c3
Compare
reitermarkus
force-pushed
the
priority-grouping
branch
from
3f028a8
to
4e0526f
Compare
|
@adamgreig, I extracted the unrelated changes from this PR. Should be easier to review now. |
reitermarkus
commented
May 10, 2022
| /// Priority grouping 6 | ||
| Prigroup6 = 6, | ||
| /// Priority grouping 7 | ||
| Prigroup7 = 7, |
There was a problem hiding this comment.
I think these values are actually swapped, at least compared to the ST HAL.
reitermarkus
commented
May 10, 2022
| /// Priority grouping 6 | ||
| Prigroup6 = 6, | ||
| /// Priority grouping 7 | ||
| Prigroup7 = 7, |
There was a problem hiding this comment.
I think these values are actually swapped, at least compared to the ST HAL.
|
@adamgreig, ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update
interrupt::freeto passCriticalSection<'_>instead of a reference.