Implement parsing & resolving lnurls #2
Conversation
benthecarman
force-pushed
the
lnurl
branch
2 times, most recently
from
3acd077 to
a8644fe
Compare
src/lib.rs
Outdated
| @@ -944,6 +947,38 @@ impl PaymentInstructions { | |||
| )) | |||
| }, | |||
| } | |||
| } else if let Some((_, data)) = | |||
There was a problem hiding this comment.
Isn't this supposed to support decoding any part of the string that contains lnurl* rather than only if the full string is lnurl*? I saw a checkout not long ago that used a QR code to display, eg https://a.website/to-visit?lnurl=lnurlasdfwerqwer so that users who just scan the QR code go to their website but if a wallet scans it it will resolve the lnurl.
There was a problem hiding this comment.
just learned thats a thing, will add
https://github.com/lnurl/luds/blob/luds/01.md#fallback-scheme
| @@ -111,10 +111,14 @@ pub trait HrnResolver { | |||
| /// can be further parsed as payment instructions. | |||
| fn resolve_hrn<'a>(&'a self, hrn: &'a HumanReadableName) -> HrnResolutionFuture<'a>; | |||
|
|
|||
| /// Resolves the given Lnurl into a [`HrnResolution`] containing a result which | |||
There was a problem hiding this comment.
An Lnurl isn't a well-defined thing, I believe? This needs to specify what, exactly, the url parameter is (a URL for an LNURL endpoint, and not the encoded LNURL...... strings).
There was a problem hiding this comment.
An lnurl is just a bech32 encoded url https://github.com/lnurl/luds/blob/luds/01.md
Everything works off of calling the first first URL as a GET request and then seeing which kind it is and handling it from there. This function is that first GET request
| @@ -111,10 +111,14 @@ pub trait HrnResolver { | |||
| /// can be further parsed as payment instructions. | |||
| fn resolve_hrn<'a>(&'a self, hrn: &'a HumanReadableName) -> HrnResolutionFuture<'a>; | |||
|
|
|||
| /// Resolves the given Lnurl into a [`HrnResolution`] containing a result which | |||
| /// can be further parsed as payment instructions. | |||
| fn resolve_lnurl<'a>(&'a self, url: &'a str) -> HrnResolutionFuture<'a>; | |||
There was a problem hiding this comment.
Should we rename the trait now that its resolving more than HRNs? I think I'm fine with no, because we really want this to be about HRNs, we just happen to support LNURL too, but still.
There was a problem hiding this comment.
Yeah I figured it was simpler to keep the name. At this point basically every lnurl-pay is a lightning address, for most cases this is just splitting out the 2 lnurl calls into separate functions instead of a single one
|
Added support for the fallback lnurl stuff and added tests for the lnurl parsing |
No description provided.