Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overdwell at times around syncloss while cranking #6349 #6351

Closed
wants to merge 1 commit into from

Conversation

rusefillc
Copy link
Contributor

huh why conditional on limitedSpark?

@mck1117
Copy link
Member

mck1117 commented Apr 10, 2024

huh why conditional on limitedSpark?

because if the actual dwell start was skipped (ie, limitedSpark is true) then there's no reason to schedule the cancellation

@rusefillc rusefillc force-pushed the master branch 2 times, most recently from 6330cb7 to e83ec13 Compare April 20, 2024 02:01
@rusefillc rusefillc marked this pull request as draft April 20, 2024 16:17
huh why conditional on limitedSpark?
@rusefillc rusefillc force-pushed the reducing-overdwell-condition branch from a116fb7 to bb470a1 Compare April 20, 2024 16:18
@rusefillc rusefillc force-pushed the master branch 3 times, most recently from 3e31934 to 608aba4 Compare April 23, 2024 19:03
@rusefillc rusefillc force-pushed the master branch 8 times, most recently from d537879 to 71e1397 Compare May 1, 2024 16:32
@rusefillc rusefillc force-pushed the master branch 4 times, most recently from c12f275 to 7888a54 Compare May 13, 2024 02:37
@rusefillc rusefillc closed this May 24, 2024
@rusefillc rusefillc deleted the reducing-overdwell-condition branch May 24, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants