Add soft delete #468
Open
Add soft delete #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgbkrk
reviewed
Aug 28, 2025
| .prepare("SELECT owner_id, created_at FROM notebooks WHERE id = ?") | ||
| .prepare( | ||
| "SELECT owner_id, created_at FROM notebooks WHERE id = ? AND deleted_at IS NULL" | ||
| ) | ||
| .bind(notebookId) | ||
| .first<{ owner_id: string; created_at: string }>(); |
There was a problem hiding this comment.
If we're listing permissions on this particular notebook, I feel like we don't have to do the delete check. That's metadata to worry about when choosing whether or not to show it in the notebook dashboard.
rgbkrk
reviewed
Aug 28, 2025
| .prepare("SELECT 1 FROM notebooks WHERE id = ? AND owner_id = ?") | ||
| .prepare( | ||
| "SELECT 1 FROM notebooks WHERE id = ? AND owner_id = ? AND deleted_at IS NULL" | ||
| ) |
There was a problem hiding this comment.
Same for this one. Someone can still own a deleted notebook.
rgbkrk
reviewed
Aug 28, 2025
| @@ -378,7 +378,7 @@ export const appRouter = router({ | |||
| } | |||
| }), | |||
|
|
|||
| // Delete notebook | |||
| // Delete notebook (soft delete) | |||
| deleteNotebook: authedProcedure | |||
There was a problem hiding this comment.
Could probably call this softDeleteNotebook now, so that someday when we bring in real delete that has a way to go.
rgbkrk
reviewed
Aug 28, 2025
| WHERE user_id = ? AND permission = 'writer' AND notebook_id IN (${placeholders})` | ||
| `SELECT np.notebook_id FROM notebook_permissions np | ||
| INNER JOIN notebooks n ON np.notebook_id = n.id | ||
| WHERE np.user_id = ? AND np.permission = 'writer' AND n.deleted_at IS NULL AND np.notebook_id IN (${placeholders})` |
There was a problem hiding this comment.
I do think the deleted_at check goes outside of the permissions provider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ai-generated soft delete