Feature/cell visibility toggles #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add sourceVisible and outputVisible boolean fields to cells table - Add cellSourceVisibilityToggled and cellOutputVisibilityToggled events - Add corresponding materializers for visibility state updates - Default both visibility fields to true for backward compatibility
- Add Eye and EyeOff icons to cell controls on hover - Add toggle handlers for source and output visibility - Wrap source textarea in sourceVisible conditional - Wrap output area in outputVisible conditional - Add visual separator between visibility toggles and other controls - Use muted styling when content is hidden
- Add visibility toggle handlers and buttons to SQL cell controls - Wrap query textarea in sourceVisible conditional - Wrap query results in outputVisible conditional - Output toggle only shows when results are available - Maintain consistent styling with other cell types
- Add visibility toggle handlers and buttons to AI cell controls - Wrap prompt textarea in sourceVisible conditional - Wrap AI responses in outputVisible conditional - Output toggle only shows when responses are available - Consistent behavior across all cell types
- Replace hasActiveKernel with activeKernel in status text logic - Add proper handling for stale kernel connections - Update color indicators to include stale state with amber color - Resolve inconsistency between main status and detailed panel - Stale kernels now show 'Connected (Stale)' instead of 'Disconnected'
- Remove output toggle from cell controls for all cell types - Add output toggle to right side of execution summary bar - Position toggle next to execution time for better context - Use smaller button size (h-5 w-5) to fit in summary bar - Only show toggle when output exists to hide - Improves UX by placing control near the content it affects
- Replace Eye/EyeOff icons with ChevronUp/ChevronDown for less creepy UI - Add hover/focus visibility to output toggles (fade when not active) - Update tooltip text to be more descriptive (Hide/Show instead of Toggle) - ChevronUp = visible content, ChevronDown = hidden content - Output toggle only appears on hover or when cell is focused
- Replace ChevronUp/ChevronDown with ArrowUp/ArrowDown for move controls - Resolves icon conflict with visibility toggles using chevrons - ArrowUp/ArrowDown more clearly indicate directional movement - ChevronUp/ChevronDown reserved for show/hide content actions
- Move play button up when source is hidden to align with cell header - Conditional positioning: 0.375rem when visible, -1.5rem when hidden - Prevents disconnected play button appearance in collapsed state - Applied to all cell types: Code, SQL, and AI cells
- Mark Source/Output Display Toggles as completed - Document implemented features and modified files - Add branch reference for review - Update current session status
rgbkrk
added a commit
that referenced
this pull request
Jun 18, 2025
- Remove outdated 'today's tasks' that were from yesterday - Add comprehensive summary of recent achievements from git log - Document all 24 .md files in project with proper categorization - Update priorities to focus on AI tool calling and integration testing - Reflect actual current status: solid foundation ready for next phase - Remove completed task details, focus on what's next Major recent progress includes: - AI context integration with visibility controls (#47, #45, #44) - Runtime stability fixes and optimization (#50, #49, #46) - ANSI handling improvements (#54) - UI enhancements and bug fixes (#55, #53, #52) - Comprehensive documentation updates
rgbkrk
added a commit
that referenced
this pull request
Jun 18, 2025
* chore: remove leftover files and scripts - Remove test-rich-output.py and test-terminal-detection.py from root - Remove start-dev.sh and reset-local-storage.cjs scripts - Remove reset-storage npm script that referenced deleted file - These were leftover from recent PR work and not actively used - User runs individual pnpm commands directly as needed * docs: update HANDOFF.md to reflect current progress - Remove outdated 'today's tasks' that were from yesterday - Add comprehensive summary of recent achievements from git log - Document all 24 .md files in project with proper categorization - Update priorities to focus on AI tool calling and integration testing - Reflect actual current status: solid foundation ready for next phase - Remove completed task details, focus on what's next Major recent progress includes: - AI context integration with visibility controls (#47, #45, #44) - Runtime stability fixes and optimization (#50, #49, #46) - ANSI handling improvements (#54) - UI enhancements and bug fixes (#55, #53, #52) - Comprehensive documentation updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide/show cells