More materializers #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add cellId to ExecutionStarted event schema - Remove ctx.query() call from ExecutionStarted materializer - Update all event commits to include cellId in the payload This fixes another potential source of materializer hash mismatches that could cause LiveStore to shut down unexpectedly. All materializers are now deterministic and side-effect free.
- Fix undefined variable references in execution-flow.test.ts - Properly destructure cellId in forEach loops - All TypeScript errors resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34.
cellIdtoExecutionStartedevent schemactx.query()call fromExecutionStartedmaterializercellIdin the payloadThis fixes another potential source of materializer hash mismatches that
could cause LiveStore to shut down unexpectedly. All materializers are
now deterministic and side-effect free.