Fix materializer hash mismatch by making Execution* materializers deterministic #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… materializers deterministic - Add cellId to ExecutionCompleted and ExecutionCancelled event schemas - Remove ctx.query() calls from materializers to make them pure functions - Update all event commits to include cellId in the payload - This fixes LiveStore.UnexpectedError about materializer hash mismatch The issue was that materializers were using ctx.query() to look up cellId during materialization, making them non-deterministic. LiveStore requires materializers to be pure functions without side effects, with all necessary data passed via the event payload.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cellIdtoExecutionCompletedandExecutionCancelledevent schemasctx.query()calls from materializers to make them pure functionsLiveStore.UnexpectedErrorabout materializer hash mismatchThe issue was that materializers were using
ctx.query()to look upcellIdduring materialization, making them non-deterministic. LiveStore requires materializers to be pure functions without side effects -- all data must be passed via the event payload.