Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUN-2369 Login as local user doesn't evaluate case sensitive feature #9123

Conversation

Jesus-Osuna-M
Copy link
Contributor

@Jesus-Osuna-M Jesus-Osuna-M commented May 16, 2024

Related to https://github.com/rundeckpro/rundeckpro/pull/3681

improve method findUserByLoginCaseSensitivity to avoid undesired logins

@Jesus-Osuna-M Jesus-Osuna-M changed the title Simplify findLoginUserByUsername method, add validation to avoid regex RUN-2369 Login as local user doesn't evaluate case sensitive feature May 16, 2024
@Jesus-Osuna-M Jesus-Osuna-M added this to the 5.3.0 milestone May 16, 2024
@Jesus-Osuna-M Jesus-Osuna-M marked this pull request as ready for review May 16, 2024 21:06
@Jesus-Osuna-M Jesus-Osuna-M modified the milestones: 5.3.0, 5.4.0 May 16, 2024
Copy link
Contributor

@mrdubr mrdubr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, assuming the test suite has tests for this already

@Jesus-Osuna-M Jesus-Osuna-M merged commit 5edca0a into main May 16, 2024
6 checks passed
@Jesus-Osuna-M Jesus-Osuna-M deleted the RUN-2369-login-as-local-user-doesnt-evaluate-case-sensitive-feature branch May 16, 2024 22:24
Copy link

💚 All backports created successfully

Status Branch Result
release/5.3.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Jesus-Osuna-M added a commit that referenced this pull request May 16, 2024
[release/5.3.x] Merge pull request #9123 from rundeck/RUN-2369-login-as-local-user-doesnt-evaluate-case-sensitive-feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants