RUN-2193, RUN-2194, RUN-2195: :nextUI: convert forecast page #9121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk hasn't found any issues so far.✅ code/snyk check is completed. No issues were found. (View Details) |
gschueler
reviewed
May 21, 2024
Questions:
|
smartinellibenedetti
force-pushed
the
RUN-2195
branch
from
81a132b
to
3da3cb5
Compare
|
@smartinellibenedetti a) yes, functional changes should increase API version so users of older API versions have old behavior. Bug fixes would not require that. b) yes let's do 2 prs |
|
@gschueler PR for api changes are here: #9143 and updated this PR to just have the component changes |
smartinellibenedetti
force-pushed
the
RUN-2195
branch
from
c064053
to
d1cadde
Compare
This reverts commit d1cadde.
gschueler
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bugfix, or an enhancement? Please describe.
This PR is part of the changes necessary for the vue conversion of the schedule forecast page (RUN-2193, RUN-2194 and RUN-2195).
Update the project select dropdown to allow multiple selections.
Describe the solution you've implemented
ProjectSelect accepts now a mode prop, whose value will determine its behavior. If "single", projectSelect will render links that upon click will take the user to the project page, if "multi", ProjectSelect will emit an array with the names of the selected projects.
Also, ProjectSelectButton can render a label in accordance to the number of projects selected.
Describe alternatives you've considered
Adapt vue-multiselect, which was asked to change in prol of reusing the projectSelect.
Additional context
Will add tests in a separate PR along with the tests for the full component behavior.