refactor(email): Split the webmail into a separate app #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks very promising @tadzik ! |
Because it's now no longer the "main" app, and only loaded when it's actually needed it won't interfere with the usage of Runbox7 unrelated to emails themselves: for example allowing to renew the account through payments-app without the searchservice and checks for new messages interfering and failing due to an expired account.
tadzik
force-pushed
the
tadzik/email-app-refactor
branch
from
fba4271 to
43cc321
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it's now no longer the "main" app, and only loaded when it's
actually needed it won't interfere with the usage of Runbox7 unrelated
to emails themselves: for example allowing to renew the account through
payments-app without the searchservice and checks for new messages
interfering and failing due to an expired account.