Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(payments): Upgrade to latest version of Stripe SDK #1669

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

castaway
Copy link
Contributor

@castaway castaway commented Mar 10, 2025

Switches from card elements to "payment element" which draws all the card fields for us, it will also allow the customer to use Link, PayPal, Apple Pay and Google Pay (if enabled in Stripe), as well as re-use saved card details

Notes / implementation details:

  • I am switching the implementation from "card elements" to "payment element", this is a recommended upgrade
  • The actual version of the SDK in-use by backend API calls is set in the stripe account, my backend patch adds a way to change it via the API call for testing.
  • we are using (for which I cannot find reasons), the deferred payment (collect details, then create payment intent), and the finalize payments on the server functionality I am keeping this in case there were reasons
  • This all works apart from: Enabling the "re-use payment details" / "present a checkbox to save payment details" functionality - the "create customer session" part required for this does work, so I am baffled why there is no checkbox / previous details shown.

Links:

Fixes: #1448

@castaway castaway force-pushed the castaway/1448_payment_fields branch 2 times, most recently from 2cd067a to 7e2d713 Compare March 19, 2025 15:16
@castaway castaway force-pushed the castaway/1448_payment_fields branch from 7e2d713 to fe1ceb6 Compare March 19, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#Payment: Card payment details box will not accept any input
1 participant