feat(oauth2-proxy): add sidecar oauth2-proxy #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMartinez-Sisti
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Hi @DrummyFloyd, appreciate the time you took to create this, but as this comment states:
I think adding the wrapper chart example to the docs and example folder
will be a best approach.
We prefer to not include components that are not part of the chart since we don't want to maintain things we don't control.
Can you update to include that instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
oauth2-proxy sidecar
why
Many people ask for something similar
tests
references
Closes: #330