fix: ignore policies-passed requirement when validating plan command #5995
+26
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
bug
> See runatlantis#5993 https://github.com/runatlantis/atlantis/pulls/5851 introduced a change to check the `policy_check` status before running a plan. if the policy checks had previously failed, the plan would fail. When using policy checks, this requirement is always injected with no way to remove it. > Specifying `repos[*].plan_requirements` does not work - the value seems to be overwritten somewhere. This PR updates the validation to ignore that requirement when present in `ProjectContext.PlanRequirements`. > It seems that after a failure, atlantis updates its internal state to a point _before_ the policy check - so any subsequent plan will succeed Signed-off-by: Lewis W. Miller <[email protected]>
nightmarlin-wise
force-pushed
the
fix/validation/i-5993-ignore-failed-policy-checks-on-plan
branch
from
123042d to
b513f8a
Compare
nightmarlin-wise
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This PR updates the
plancommand's validator to ignore thepolicies_passedrequirement when present inProjectContext.PlanRequirements.This resolves issue #5993 introduced by #5851: When a policy check fails, the subsequent plan always fails. Plans run after this run as normal.
Specifying
repos[*].plan_requirements: []in the server-siderepos.yamldoes not successfully work around the issue - the value seems to be overwritten somewhere.why
This fixes an issue with the standard use case for policy checks. We want to upgrade to the latest atlantis version to make use of parallel plan & apply - but the additional friction caused by this (and potential contacts from teams not familiar with atlantis) means we cannot adopt this version.
I believe atlantis can only run policy checks after a plan is completed, so this small-scoped solution makes the most sense to me. If this assumption is wrong, I'd be happy to look into an alternative solution that fits a broader set of use cases!
tests
references