fix: Fix API pre-workflow hook execution order and enable auto-discovery #5994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
/api/planand/api/applyendpoints to run pre-workflow hooks before building commands instead of afterProjectsandPathsfields are empty in API requestsatlantis.yamlfiles (via pre-workflow hooks) could not be used with the APIwhy
atlantis.yamlbefore pre-workflow hooks could generate it"cannot specify a project name unless an atlantis.yaml file exists"errors for repos using dynamic config generationatlantis plan(no args) behaviorterragruntworkflow)Execution Order Before Fix:
API: Clone → Load Config ❌ → Build Commands → Run Pre-Hooks (too late) Comment: Clone → Run Pre-Hooks ✅ → Load Config → Build Commands
Execution Order After Fix:
API: Clone → Run Pre-Hooks ✅ → Load Config → Build Commands Comment: Clone → Run Pre-Hooks ✅ → Load Config → Build Commands
tests
atlantis.yamlvia pre-workflow hooks - config now generates before being readProjects: ["dev"]properly resolve project configurations and apply repo-level workflowsProjectsandPathsare omitted from API request"overriding server-defined workflow with repo-specified workflow"