fix(gitea): add src as context for gitea status updates #5975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
bug
maddawik
force-pushed
the
patch-1
branch
3 times, most recently
from
88ad904 to
cbf9616
Compare
This makes it possible for status checks to be pattern matched in branch protection rules. i.e. `atlantis/plan` and `atlantis/apply` could be required. Signed-off-by: maddawik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Updates the
GiteaClient.UpdateStatusmethod so thatsrc(which should beatlantis/planoratlantis/applyafaict) is passed as theContextfor thegitea.CreateStatusOptionstruct. This should give status checks names which can be seen in the UI and pattern matched against. This seems like how the other clients are passing the status name along as well.why
This should make it possible for status checks to be pattern matched in branch protection rules. i.e.
atlantis/planandatlantis/applycould be explicitly required before merge.tests
I don't see any related tests for the client though this is my first PR, so if I'm missing something I'm happy to address it.
Edit: I tested this locally
Before patch
Status updates have no name, a branch protection rule that has
atlantis/*means nothing in this context (see screenshot)After patch
I built the patched version locally and re-ran a test, seeing context appear and able to assert branch protection rules. I think this was as simple as it seemed!
references
Closes #5802