fix: Use correct command name for ApprovePolicies #5934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
bug
chenrui333
reviewed
Nov 12, 2025
Signed-off-by: Luke Massa <[email protected]>
lukemassa
force-pushed
the
use_correct_command_name
branch
from
a2d0278 to
64e37f3
Compare
Signed-off-by: Luke Massa <[email protected]>
Contributor
Author
|
I have a different idea how to fix this, moving to WIP for now |
auto-merge was automatically disabled
November 15, 2025 19:08
Pull request was converted to draft
This was referenced Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Change the command name for the project result of ApprovePolicies to the approve policies command.
why
The command being worked on is
ApprovePoliciesbut we returning as if it ran thePolicyCheckcommand.As far as I can tell this bug has been present since this code was introduced: af2a806#diff-eb466bb07e603dbf2a2a91c776b4d812bf330b3dc02fcaf762380b0078296937R174
I frankly don't quite understand what this does, but if you look at the rest of the doXYZ in plan_command_runner, they follow a particular pattern of referring to commands, and this one simply seems to have been typod.
tests
N/A
references
N/A