fix: status always success when using custom policy #5156
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakuljajan
requested review from
chenrui333,
lukemassa and
X-Guardian
and removed request for
a team
Signed-off-by: ekapratama93 <[email protected]>
bakuljajan
force-pushed
the
fix/vcs-status-custom-policy
branch
from
d57b7ad to
e1317da
Compare
|
@bakuljajan, do you think you could add a test for this? Thanks. |
Signed-off-by: bakuljajan <[email protected]>
Hi @jamengual thanks for looking into this PR, I'm unfamiliar with writing golang code, but enabling the Let me know if you need me to add more test cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
try to fix #4585. It seems the original code does not return error when the custom policy is enabled.
why
the error status was skipped causing plan/apply combined with custom policy check to always be successful.
tests
manual test only. will need guidance if additional tests are needed.
references
#4585
possibly #4861