Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change GitLab UpdateStatus Function to get Pipeline from Commit rather than the Merge Request #5033

Merged
merged 6 commits into from
Nov 11, 2024

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented Oct 23, 2024

what

Change the GitLab Client UpdateStatus function to get the pipeline ID from the commit that was used to trigger the Atlantis run, rather than the head pipeline of the Merge Request.

why

tests

Tested locally and unit tests updated

I also refactored all the GitLab Client Update Status tests to use proper JSON handling.

References

@X-Guardian X-Guardian requested review from a team as code owners October 23, 2024 21:03
@X-Guardian X-Guardian requested review from jamengual, lukemassa and nitrocode and removed request for a team October 23, 2024 21:03
@github-actions github-actions bot added go Pull requests that update Go code provider/gitlab labels Oct 23, 2024
@dosubot dosubot bot added the bug Something isn't working label Oct 23, 2024
Signed-off-by: X-Guardian <[email protected]>
@X-Guardian X-Guardian force-pushed the gitlab-updatestatus-fix branch from 0940225 to a54768a Compare October 23, 2024 21:08
@jamengual
Copy link
Contributor

@lukemassa do you have time to take a look?

@X-Guardian
Copy link
Contributor Author

Once the container image has finished building from this PR, I will test it further on my company's non-prod Atlantis instance.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 8, 2024
@jamengual
Copy link
Contributor

Once the container image has finished building from this PR, I will test it further on my company's non-prod Atlantis instance.

did you have a chance to test this?

@X-Guardian
Copy link
Contributor Author

Once the container image has finished building from this PR, I will test it further on my company's non-prod Atlantis instance.

did you have a chance to test this?

Apparently publishing dev images from PR commits has been disabled, so I can't test until it is merged and a dev image is published.

@X-Guardian X-Guardian merged commit 8c6541f into runatlantis:main Nov 11, 2024
34 checks passed
@X-Guardian X-Guardian deleted the gitlab-updatestatus-fix branch November 11, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working go Pull requests that update Go code lgtm This PR has been approved by a maintainer provider/gitlab
Projects
None yet
3 participants