chore: log permissions external command

[chadinwork]

what

• Add logs for when permissions external command decides user does not have permission (Example: command '/etc/scripts/authorization.sh apply repo/here ' returns 'the custom script echo goes here' such as command '/etc/scripts/authorization.sh apply repo/here ' returns 'user \"chadin\" must be a member of \"alice, bob\" to apply changes.')
• Add logs for when permissions external command errors out (Example: Command returns exit code 1: Command '/etc/scripts/authorization.sh apply repo/here ' error 'exit status 1: running \"sh -c /etc/scripts/authorization.sh apply repo/here \": \nuser \"chadin\" must be a member of \"xx, yy\" to apply changes.\n')
• Add logs for when user does not have permission (Example: User 'chadin' in team '[]' does not have permissions to execute the 'apply' command)

why

• Increase transparency when permissions external command concludes that user does not have permission

tests

• I have tested my changes by running make test and make test-all in Docker. All tests passed
• Give me a while to run manual tests to confirm the logs are actually emitted (need just a bit more time to set up test Terraform repo) Tested and verified working!

references

• closes Log command and output of Repo and Project Permissions: External Command #4942

[X-Guardian]

Thanks for this @chadinwork. Can you use '%s' rather than %q in the log messages to use single quotes though, as the double quotes need to be escaped in the JSON logs and make it harder to read.

[chadinwork]

Sure @X-Guardian, I was following https://github.com/runatlantis/atlantis/blob/main/CONTRIBUTING.md which asked for %q.

Updated!

[X-Guardian]

Sure @X-Guardian, I was following https://github.com/runatlantis/atlantis/blob/main/CONTRIBUTING.md which asked for %q.

Good spot. I'll get that updated.

[X-Guardian]

Can you also add some sample log output from these changes to the PR description, so that we can see what they look like.

[chadinwork]

@X-Guardian I've applied suggested changes, and added examples. Let me know if anything else is needed!

FYI: I'm out of town from tomorrow onwards for one week, so in case I miss your replies before I go, I'll come back and attend to them after I return.

[X-Guardian]

I'm not convinced that these should be Info messages. I think Debug would be better, so they only display when an Atlantis command is run with the -verbose flag . Same below.

Your examples in the description aren't useful, as they are made up. Please can you provide real world usage messages.

[github-actions]

This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month.