fix: implement backoff + retry when GitLab SetCommitStatus returns 409 #4503
+63
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
GitLab returns a
409 Conflict
status when the commit pipeline status is being changed/locked by another request, which is likely to happen if you use [--parallel-pool-size > 1
] and [parallel-plan|apply
].The likelihood of this happening is increased when the number of parallel apply jobs is increased.
why
Returning the [err] without retrying will permanently leave the GitLab commit status in a "running" state, which would prevent Atlantis from merging the merge request on [apply]. GitLab does not allow merge requests to be merged when the pipeline status is "running."
tests
We've been running these changes in our environment for months and it has eliminated this type of error entirely