Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added disable-unlock-label config option #3799

Merged
merged 8 commits into from
Oct 10, 2023
Merged

feat: Added disable-unlock-label config option #3799

merged 8 commits into from
Oct 10, 2023

Conversation

kvanzuijlen
Copy link
Contributor

@kvanzuijlen kvanzuijlen commented Sep 28, 2023 •
edited
Loading

what

Adds an option to disable the unlock command on PRs that have a certain label.

why

  • Prevents colleagues to accidentally unlock PRs that should not be unlocked. A label is a clear indicator to the user that it should not be touched.

tests

  • I have tested my changes by writing unit tests

references

@kvanzuijlen kvanzuijlen requested a review from a team as a code owner September 28, 2023 12:21
@github-actions github-actions bot added the go Pull requests that update Go code label Sep 28, 2023
@kvanzuijlen kvanzuijlen changed the title Added disable-unlock-label config option feat: Added disable-unlock-label config option Sep 28, 2023
@GenPage GenPage added feature New functionality/enhancement quick-win Is obviously something Atlantis should do and will take <4 hrs work waiting-on-review Waiting for a review from a maintainer labels Sep 28, 2023
@GenPage GenPage self-assigned this Sep 28, 2023
@kvanzuijlen
Copy link
Contributor Author

I'll take a look at the tests @GenPage!

@kvanzuijlen
Copy link
Contributor Author

kvanzuijlen commented Sep 29, 2023 •
edited
Loading

@GenPage I've fixed the unit tests.

@jamengual
Copy link
Contributor

@kvanzuijlen Please add documentation on the Server config page

@github-actions github-actions bot added the docs Documentation label Sep 29, 2023
@kvanzuijlen kvanzuijlen mentioned this pull request Oct 2, 2023
Open
1 task
@GenPage GenPage removed the waiting-on-review Waiting for a review from a maintainer label Oct 6, 2023
@GenPage GenPage merged commit 786e57c into runatlantis:main Oct 10, 2023
14 checks passed
@kvanzuijlen kvanzuijlen deleted the add-disable-unlock-label branch October 10, 2023 15:23
@bschaatsbergen
Copy link
Member

Nice work @kvanzuijlen 👍🏼 - happy to see you're contributing here!

@BrewTestBot BrewTestBot mentioned this pull request Dec 12, 2023
Merged
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@kvanzuijlen @jamengual @ijames-gc
feat: Added disable-unlock-label config option (runatlantis#3799)
4a43f8a 
* Added disable-unlock-label config option

* Fixed tests

* Wrote tests + fixed mistakes

* Added docs

* added defaults to docs

---------

Co-authored-by: PePe Amengual <[email protected]>
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@kvanzuijlen @jamengual @ijames-gc
feat: Added disable-unlock-label config option (runatlantis#3799)
9c14302 
* Added disable-unlock-label config option

* Fixed tests

* Wrote tests + fixed mistakes

* Added docs

* added defaults to docs

---------

Co-authored-by: PePe Amengual <[email protected]>
@BrewTestBot BrewTestBot mentioned this pull request May 22, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GenPage GenPage GenPage approved these changes

Assignees

@GenPage GenPage

Labels
docs Documentation feature New functionality/enhancement go Pull requests that update Go code quick-win Is obviously something Atlantis should do and will take <4 hrs work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Block atlantis unlock if label exists on PR
4 participants
@kvanzuijlen @jamengual @bschaatsbergen @GenPage