Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep(parse-url): replace with native URL #45

Merged
merged 7 commits into from
Dec 15, 2023

Conversation

msimerson
Copy link

@msimerson msimerson commented Dec 10, 2023

  • native URL requires node 10 (previous was v8)
  • fix(prettier-plugin-eslint): pin v4, v3 not compatible
  • replace Travis CI with GHA

Notes

  • In Critical CVE with parse-url dependency nodertc/stun#37, the author recommends replacing parse-url. I agree with him.
  • CI with GitHub Actions has been tested and you can see the output over here in my fork. I updated the readme file so that if you merge this PR, the CI test badge points to the GHA CI tests in your repo.
  • the CI tests automatically test against every LTS version of node.js. Currently that's node 18 & 20.
  • If you have a coveralls.io account, after merging this PR coveralls will show results in your fork. For now, I've got the badge URL pointed at my fork.

CI Sample

Screenshot 2023-12-09 at 4 31 01 PM

- ci(win): disable windows tests, prettier fails
@rumaf rumaf merged commit 458b616 into rumaf:master Dec 15, 2023
@msimerson msimerson deleted the ditch-parse-url branch December 15, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants