core: Fix BG music not stopping in Samorost (close #963) #13781
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MovieClip avm1_unload()
was already stopping the current stream at https://github.com/ruffle-rs/ruffle/blob/5bebebddbe3c39362ba520cb0c9c28b3cb7f72a3/core/src/display_object/movie_clip.rs#L2924C18-L2924C18 but in Samorost, the BG music that keeps playing after switching SWFs in ruffle is not a stream but a sound.I don't know how to make it stop only the sound that's currently playing, so here's a "fix" that just stops them all. Technically closes #963 but there may be a neater way.