Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate sample event column to text for reporting #5503

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

itsmihir
Copy link
Contributor

@itsmihir itsmihir commented Feb 12, 2025

Description

Recently, we migrated the jobsDB payload column to the text type; however, in the reports and error_detail_reports tables, we still use the jsonb type to store sample_event. This has led to instances where Postgres failed to cast sample_event from string to jsonb due to special characters, resulting in processor panics.
This PR migrates the sample_event column in these tables from jsonb to text to ensure consistency and prevent such failures.

Linear Ticket

Resolves OBS-776

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@itsmihir itsmihir changed the title chore: migrate sample event col to text chore: migrate sample event column to text for reports and error_reports table Feb 12, 2025
@itsmihir itsmihir changed the title chore: migrate sample event column to text for reports and error_reports table chore(reporting): migrate sample event column to text Feb 12, 2025
@itsmihir itsmihir changed the title chore(reporting): migrate sample event column to text chore: migrate sample event column to text for reporting Feb 12, 2025
@itsmihir itsmihir marked this pull request as ready for review February 13, 2025 14:33
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.02%. Comparing base (734e759) to head (6230d61).

Files with missing lines Patch % Lines
processor/processor.go 64.28% 5 Missing ⚠️
router/batchrouter/handle.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5503      +/-   ##
==========================================
- Coverage   75.04%   75.02%   -0.03%     
==========================================
  Files         460      460              
  Lines       63548    63548              
==========================================
- Hits        47692    47675      -17     
- Misses      13204    13219      +15     
- Partials     2652     2654       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant