Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove payload logging #5447

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Sidddddarth
Copy link
Member

@Sidddddarth Sidddddarth commented Jan 21, 2025

Description

Remove logs that can expose event payloads.

Linear Ticket

Resolves PIPE-1825

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.08%. Comparing base (134fbc0) to head (3dc8445).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
gateway/handle.go 0.00% 4 Missing ⚠️
router/transformer/transformer.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5447      +/-   ##
==========================================
+ Coverage   74.76%   75.08%   +0.32%     
==========================================
  Files         440      462      +22     
  Lines       61705    63800    +2095     
==========================================
+ Hits        46132    47905    +1773     
- Misses      13022    13231     +209     
- Partials     2551     2664     +113     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sidddddarth Sidddddarth changed the title chore: remove payload logging in gateway chore: remove payload logging Jan 23, 2025
Copy link

This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gw.logger.Debugn("response",

we can remove from here also

@github-actions github-actions bot removed the Stale label Feb 14, 2025
@Sidddddarth Sidddddarth marked this pull request as ready for review February 21, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants