Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid error response handling during oauth refresh flow #5401

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

sanpj2292
Copy link
Contributor

@sanpj2292 sanpj2292 commented Dec 30, 2024

Description

There is a new error being thrown from config-backend's /token endpoint, when the response from downstream service is not valid(i.e, refresh has not happened). We are trying to understand the response and respond correctly.

When config-backend returns INVALID_REFRESH_RESPONSE error, we would retry the event with appropriate error message

Linear Ticket

Resolves INT-2963

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@sanpj2292 sanpj2292 requested a review from koladilip December 30, 2024 09:26
@sanpj2292 sanpj2292 self-assigned this Dec 30, 2024
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.85%. Comparing base (d29eb14) to head (845ecdb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5401      +/-   ##
==========================================
+ Coverage   74.76%   74.85%   +0.09%     
==========================================
  Files         439      439              
  Lines       61378    61388      +10     
==========================================
+ Hits        45890    45953      +63     
+ Misses      12943    12894      -49     
+ Partials     2545     2541       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanpj2292 sanpj2292 requested a review from ItsSudip January 2, 2025 07:14
@sanpj2292 sanpj2292 merged commit a801e3d into master Jan 6, 2025
60 checks passed
@sanpj2292 sanpj2292 deleted the fix.oauth-invalid-error-resp branch January 6, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants